Fix: Complete futures on shutdown#746
Closed
acocuzzo wants to merge 7 commits intogoogleapis:mainfrom
Closed
Conversation
product-auto-label
bot
added
size: m
acocuzzo
changed the title
4 tasks
pedroserrudo
approved these changes
Sep 18, 2023
mukund-ananthu
added
the
do not merge
Contributor
|
Closing stale PRs to prepare for the code migration to google-cloud-python. Please feel free to re-open this PR if this is actively being worked on, or open a new PR after the code has migrated to google-cloud-python. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set "shutdown_mode" in the dispatcher. During this mode, set_exception(AcknowledgeError.OTHER) on dispatched callbacks.
When unary acks, modack, and nacks are returned check they are not already completed.
Fixes googleapis/google-cloud-python#15651🦕